-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][Joint Matrix][E2E] Uncomment the Joint Matrix tests for combination 32x32x16 #16191
Open
YixingZhang007
wants to merge
1
commit into
intel:sycl
Choose a base branch
from
YixingZhang007:uncomment_test_32x32x16
base: sycl
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+15
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YixingZhang007
changed the title
[SYCL][Joint Matrix][E2E] Uncomment the Joint Matrix tests for combination 32x32x16 combination
[SYCL][Joint Matrix][E2E] Uncomment the Joint Matrix tests for combination 32x32x16
Nov 26, 2024
YixingZhang007
had a problem deploying
to
WindowsCILock
November 26, 2024 21:59
— with
GitHub Actions
Error
YixingZhang007
had a problem deploying
to
WindowsCILock
November 26, 2024 22:16
— with
GitHub Actions
Error
YixingZhang007
temporarily deployed
to
WindowsCILock
November 26, 2024 22:23
— with
GitHub Actions
Inactive
YixingZhang007
temporarily deployed
to
WindowsCILock
November 26, 2024 22:48
— with
GitHub Actions
Inactive
dkhaldi
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
YixingZhang007
force-pushed
the
uncomment_test_32x32x16
branch
from
November 29, 2024 19:02
fb3a74e
to
1785eb9
Compare
YixingZhang007
temporarily deployed
to
WindowsCILock
November 29, 2024 19:02
— with
GitHub Actions
Inactive
YixingZhang007
had a problem deploying
to
WindowsCILock
November 29, 2024 19:15
— with
GitHub Actions
Error
YixingZhang007
temporarily deployed
to
WindowsCILock
November 29, 2024 19:20
— with
GitHub Actions
Inactive
YixingZhang007
temporarily deployed
to
WindowsCILock
November 29, 2024 19:33
— with
GitHub Actions
Inactive
YixingZhang007
temporarily deployed
to
WindowsCILock
November 30, 2024 00:00
— with
GitHub Actions
Inactive
YixingZhang007
had a problem deploying
to
WindowsCILock
November 30, 2024 00:14
— with
GitHub Actions
Error
YixingZhang007
temporarily deployed
to
WindowsCILock
November 30, 2024 00:15
— with
GitHub Actions
Inactive
YixingZhang007
had a problem deploying
to
WindowsCILock
November 30, 2024 00:29
— with
GitHub Actions
Error
YixingZhang007
had a problem deploying
to
WindowsCILock
November 30, 2024 00:39
— with
GitHub Actions
Error
YixingZhang007
temporarily deployed
to
WindowsCILock
November 30, 2024 00:52
— with
GitHub Actions
Inactive
YixingZhang007
had a problem deploying
to
WindowsCILock
November 30, 2024 01:17
— with
GitHub Actions
Error
YixingZhang007
force-pushed
the
uncomment_test_32x32x16
branch
from
November 30, 2024 01:29
3eee097
to
bf10daf
Compare
YixingZhang007
temporarily deployed
to
WindowsCILock
November 30, 2024 01:30
— with
GitHub Actions
Inactive
YixingZhang007
temporarily deployed
to
WindowsCILock
November 30, 2024 01:56
— with
GitHub Actions
Inactive
@intel/llvm-gatekeepers This PR has been approved and all the CI tests have passed. Could you please help merge the PR? Thanks for helping :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The support for combination 32x32x16 on DG2 has been implemented in commit intel/intel-graphics-compiler@6a06c93. This PR re-enables the Joint Matrix tests for the combination 32x32x16, which were previously unsupported.
This PR also adds XFAIL: gpu to two tests, joint_matrix_bf16_fill_k_cache_arg_dim.cpp and joint_matrix_bf16_fill_k_cache_runtime_dim.cpp, because the driver has not yet been updated to include the necessary changes in IGC to support these tests. As a result, these tests should not be tested in CI at this time.