Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Joint Matrix][E2E] Uncomment the Joint Matrix tests for combination 32x32x16 #16191

Open
wants to merge 1 commit into
base: sycl
Choose a base branch
from

Conversation

YixingZhang007
Copy link
Contributor

@YixingZhang007 YixingZhang007 commented Nov 26, 2024

Description:
The support for combination 32x32x16 on DG2 has been implemented in commit intel/intel-graphics-compiler@6a06c93. This PR re-enables the Joint Matrix tests for the combination 32x32x16, which were previously unsupported.

This PR also adds XFAIL: gpu to two tests, joint_matrix_bf16_fill_k_cache_arg_dim.cpp and joint_matrix_bf16_fill_k_cache_runtime_dim.cpp, because the driver has not yet been updated to include the necessary changes in IGC to support these tests. As a result, these tests should not be tested in CI at this time.

@YixingZhang007 YixingZhang007 requested a review from a team as a code owner November 26, 2024 21:58
@YixingZhang007 YixingZhang007 changed the title [SYCL][Joint Matrix][E2E] Uncomment the Joint Matrix tests for combination 32x32x16 combination [SYCL][Joint Matrix][E2E] Uncomment the Joint Matrix tests for combination 32x32x16 Nov 26, 2024
@YixingZhang007 YixingZhang007 marked this pull request as draft November 26, 2024 21:58
@YixingZhang007 YixingZhang007 self-assigned this Nov 26, 2024
Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YixingZhang007
Copy link
Contributor Author

@intel/llvm-gatekeepers This PR has been approved and all the CI tests have passed. Could you please help merge the PR? Thanks for helping :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants